Re: [PATCH v3 1/1] rust: introduce abstractions for fwctl
From: Danilo Krummrich
Date: Tue Mar 03 2026 - 16:00:41 EST
On Tue Mar 3, 2026 at 9:15 PM CET, Jason Gunthorpe wrote:
>> rust/kernel/fwctl.rs | 449 ++++++++++++++++++++++++++++++++
>
> The binding is larger than the subystem file:
>
> $ wc -l drivers/fwctl/main.c
> 421 drivers/fwctl/main.c
It's probably more a positve than a negative thing, as we should have a lot of
code that is not only mindlessly forwarding things, but actually teaches the
compiler how to prevent users from making mistakes.
But yes, usually the abstractions are smaller than the component they're written
for.