Re: [PATCH v3 3/3] arm64: dts: imx91-var-dart: Add support for Variscite Sonata board

[Frank Li]

From: Frank Li (AI-BOT) <frank.li@xxxxxxx>

AI bot review and may be useless.

This is a device tree patch, not C code, so traditional kernel style rules
don't apply. However, a few observations:

> +	pinctrl_lpi2c7: lpi2c7grp {
> +		fsl,pins = <
> +			MX91_PAD_GPIO_IO07__LPI2C7_SCL			0x40000b9e
> +			MX91_PAD_GPIO_IO06__LPI2C7_SDA			0x40000b9e
> +		>;
> +	};

This pinctrl group is defined but never referenced in any &lpi2c7 node.
Consider removing it or adding the corresponding device node.

> +	pinctrl_lpi2c7_gpio: lpi2c7-gpiogrp {
> +		fsl,pins = <
> +			MX91_PAD_GPIO_IO07__GPIO2_IO7			0x31e
> +			MX91_PAD_GPIO_IO06__GPIO2_IO6			0x31e
> +		>;
> +	};

Same issue: orphaned pinctrl group with no consumer.

> +	pinctrl_rtc: rtcgrp {
> +		fsl,pins = <
> +			MX91_PAD_GPIO_IO02__GPIO2_IO2			0x31e
> +		>;
> +	};

Orphaned pinctrl group. The RTC is on I2C (address 0x68) and doesn't appear
to use this GPIO in the device tree.

> +	pinctrl_uart7: uart7grp {
> +		fsl,pins = <
> +			MX91_PAD_GPIO_IO09__LPUART7_RX			0x31e
> +			MX91_PAD_GPIO_IO08__LPUART7_TX			0x31e
> +		>;
> +	};

Orphaned pinctrl group. No &lpuart7 node is enabled.

Consider cleaning up unused pinctrl definitions or adding the corresponding
device nodes. Otherwise, the patch looks structurally sound for a carrier
board DTS.