Re: [PATCH v2 2/4] mmc: sdhci-esdhc-imx: add 1-bit bus width support
From: Frank Li
Date: Tue Mar 03 2026 - 16:03:29 EST
From: Frank Li (AI-BOT) <frank.li@xxxxxxx>
> + sdhci_get_property(pdev);
> +
Missing argument: sdhci_get_property() expects (struct sdhci_host *host)
as second parameter, not just pdev. Check function signature in
sdhci.h.
> - if (of_property_read_bool(np, "no-1-8-v"))
> - host->quirks2 |= SDHCI_QUIRK2_NO_1_8_V;
Removal looks correct if sdhci_get_property() truly handles "no-1-8-v"
internally. Verify this is documented in the commit message or code
comment to avoid future confusion.
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c
> index 97461e20425d..b607d4ffc562 100644
Line length at hunk context appears OK (under 80 chars).
---
AI bot review and may be useless.