Re: [PATCH] scsi: ufs: core: Handle MCQ IAG events

[Peter Wang (王信友)]

On Wed, 2026-03-04 at 09:02 -0600, Bart Van Assche wrote:
> Doesn't this follow from the UFSHCI standard? From the UFSHCI 5.0
> standard: "MCQ Interrupt Aggregation Event Status (IAGES): This bit
> is
> transparent and becomes ‘1’ when all of the following conditions are
> met
> • Controller is operating in MCQ mode (Config.QT = 1)
> • ESI is not enabled (Config.ESIE = 0)
> • At least one interrupt aggregation group has triggered, which means
> it
> has satisfied either counter or timer condition
> 
> When in MCQ mode, and ESI is not used, SW can use traditional
> interrupt
> approach. When this bit is set, interrupt routine needs to scan all
> interrupt aggregation groups to determine which IAG has caused this
> interrupt.
> 
> Thanks,
> 
> Bart.

Hi Bart,

I know this is absolutely correct, but reading this code is confusing:
if (cq event)
    handle cq event
if (iag event)
    handle cq event
If we cannot change it to:
if (iag event)
    handle iag event
At least, we should change the function name from
ufshcd_handle_mcq_cq_events to ufshcd_handle_mcq_cq_iag_events.

Thanks
Peter