Re: [PATCH] scsi: ufs: core: Handle MCQ IAG events

[Bart Van Assche]

On 3/4/26 9:28 PM, Peter Wang (王信友) wrote:
> I know this is absolutely correct, but reading this code is confusing:
> if (cq event)
>      handle cq event
> if (iag event)
>      handle cq event
> If we cannot change it to:
> if (iag event)
>      handle iag event

Hi Peter,

It is not clear to me why the above code is considered confusing?

UFS controllers are the only storage controllers I know of
that generate different interrupts depending on whether or not interrupt
aggregation is enabled. All other storage controllers I know of use the
same completion interrupt whether or not interrupt aggregation is
enabled.

To me the above code means that whether or not interrupt aggregation is
enabled, ufshcd_handle_mcq_cq_events() is called to process the pending
completions.

Thanks,

Bart.