Re: [PATCH] scsi: ufs: core: Handle MCQ IAG events

From: Peter Wang (王信友)

Date: Thu Mar 05 2026 - 22:49:48 EST


On Thu, 2026-03-05 at 06:07 -0600, Bart Van Assche wrote
>
> Hi Peter,
>
> It is not clear to me why the above code is considered confusing?
>
> UFS controllers are the only storage controllers I know of
> that generate different interrupts depending on whether or not
> interrupt
> aggregation is enabled. All other storage controllers I know of use
> the
> same completion interrupt whether or not interrupt aggregation is
> enabled.
>
> To me the above code means that whether or not interrupt aggregation
> is
> enabled, ufshcd_handle_mcq_cq_events() is called to process the
> pending
> completions.
>
> Thanks,
>
> Bart.

Hi Bart,

Sorry, I may not have explained it clearly enough. Normally,
the logic is to handle A when receiving A event, and handle B
when receiving B event. But now, the code seems to be hnadle A
when receiving B event.
If not familiar with this hardware logic, it’s easy to
misunderstand.

Thanks
Peter