Re: [PATCH net v2] net: sfp: improve Huawei MA5671a fixup

From: Andrew Lunn

Date: Thu Mar 05 2026 - 10:09:58 EST


> +static void sfp_fixup_huawei(struct sfp *sfp)

Please avoid using a vendor name. It is unlikely just this vendor
produces an SFP broken like this, other vendors will break their SFPs
in the same way. And then we will want to reuse this helper.

So maybe sfp_fixup_ignore_tx_fault_and_loss()?

Andrew