Re: [PATCH net v2] net: sfp: improve Huawei MA5671a fixup

[Álvaro Fernández Rojas]

El jue, 5 mar 2026 a las 16:04, Andrew Lunn (<andrew@xxxxxxx>) escribió:
>
> > +static void sfp_fixup_huawei(struct sfp *sfp)
>
> Please avoid using a vendor name. It is unlikely just this vendor
> produces an SFP broken like this, other vendors will break their SFPs
> in the same way. And then we will want to reuse this helper.

I just followed the same logic used for sfp_fixup_nokia()
https://github.com/torvalds/linux/blob/5ee8dbf54602dc340d6235b1d6aa17c0f283f48c/drivers/net/phy/sfp.c#L375-L379

>
> So maybe sfp_fixup_ignore_tx_fault_and_loss()?

Sure, I can change that in v3.

>
>    Andrew

Best regards,
Álvaro.