Re: [PATCH v2 1/3] arm64: dts: qcom: monaco-evk: Enable GPIO expander interrupt for Monaco EVK

[Swati Agarwal]

On Tue, Mar 3, 2026 at 3:29 PM Konrad Dybcio
<konrad.dybcio@xxxxxxxxxxxxxxxx> wrote:
>
> On 3/3/26 9:21 AM, Swati Agarwal wrote:
> > Enable PCA9538 expander as interrupt controller on Monaco EVK and configure
> > the corresponding TLMM pins via pinctrl to operate as GPIO inputs with
> > internal pull-ups.
> >
> > Signed-off-by: Swati Agarwal <swati.agarwal@xxxxxxxxxxxxxxxx>
> > ---
>
> [...]
>
> >  &tlmm {
> >
> > +
> Stray \n above
>
>         expander0_int: expander0-int-state {
> > +             pins = "gpio56";
>
> The TLMM entries are currently ordered by the pin index - please retain
> that.
Hi Konrad,
Do you want me to sort expander_int as per pin number and not as per
expander0_int and expander1_int.
For eg:- expander5-int-state(gpio3) followed by expander1_int(gpio16).

Regards,
Swati
>
> Otherwise, this looks good
>
> Konrad