Re: [PATCH] x86/entry/vdso: fix path to gettimeofday.c
From: Borislav Petkov
Date: Sat Mar 07 2026 - 14:10:12 EST
On Sat, Mar 07, 2026 at 07:44:06PM +0200, vladimir.oltean@xxxxxxx wrote:
> To get from arch/x86/entry/vdso/common/vclock_gettime.c to
> lib/vdso/gettimeofday.c, you need 5 "..", not 4.
>
> Proof:
> $ (cd "$(dirname arch/x86/entry/vdso/common/vclock_gettime.c)" && ls ../../../../lib/vdso/gettimeofday.c)
> ls: cannot access '../../../../lib/vdso/gettimeofday.c': No such file or directory
> $ (cd "$(dirname arch/x86/entry/vdso/common/vclock_gettime.c)" && ls ../../../../../lib/vdso/gettimeofday.c)
> ../../../../../lib/vdso/gettimeofday.c
>
> I'm blaming the commit below because it moved vclock_gettime.c from
> arch/x86/entry/vdso/vclock_gettime.c to
> arch/x86/entry/vdso/common/vclock_gettime.c
> without updating the relative include path.
>
> This shows up on an x86 allmodconfig build, I don't really know why it
> hasn't been reported so far.
I see what you mean and it does sound plausible but allmodconfig builds fine
here. Perhaps you're doing it differently from how I'm doing it ...
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette