Re: [PATCH] x86/entry/vdso: fix path to gettimeofday.c

[Vladimir Oltean]

On Sat, Mar 07, 2026 at 08:09:44PM +0100, Borislav Petkov wrote:
> On Sat, Mar 07, 2026 at 07:44:06PM +0200, vladimir.oltean@xxxxxxx wrote:
> > To get from arch/x86/entry/vdso/common/vclock_gettime.c to
> > lib/vdso/gettimeofday.c, you need 5 "..", not 4.
> > 
> > Proof:
> > $ (cd "$(dirname arch/x86/entry/vdso/common/vclock_gettime.c)" && ls ../../../../lib/vdso/gettimeofday.c)
> > ls: cannot access '../../../../lib/vdso/gettimeofday.c': No such file or directory
> > $ (cd "$(dirname arch/x86/entry/vdso/common/vclock_gettime.c)" && ls ../../../../../lib/vdso/gettimeofday.c)
> > ../../../../../lib/vdso/gettimeofday.c
> > 
> > I'm blaming the commit below because it moved vclock_gettime.c from
> > arch/x86/entry/vdso/vclock_gettime.c to
> > arch/x86/entry/vdso/common/vclock_gettime.c
> > without updating the relative include path.
> > 
> > This shows up on an x86 allmodconfig build, I don't really know why it
> > hasn't been reported so far.
> 
> I see what you mean and it does sound plausible but allmodconfig builds fine
> here. Perhaps you're doing it differently from how I'm doing it ...
> 
> -- 
> Regards/Gruss,
>     Boris.
> 
> https://people.kernel.org/tglx/notes-about-netiquette

cc="ccache gcc"
output_dir=build_allmodconfig_warn/
ncpu=$(grep -c processor /proc/cpuinfo)
build_flags="-Oline -j $ncpu W=1 C=1"
tmpfile_o=$(mktemp)
tmpfile_n=$(mktemp)

make CC="$cc" O=$output_dir allmodconfig
./scripts/config --file $output_dir/.config -d werror
./scripts/config --file $output_dir/.config -d drm_werror
./scripts/config --file $output_dir/.config -d kvm_werror
./scripts/config --file $output_dir/.config -d rust
./scripts/config --file $output_dir/.config -d security_apparmor

make CC="$cc" O=$output_dir $build_flags