Re: [PATCH 3/3] arm64: dts: qcom: sm8250-asus-obiwan: Add ASUS ROG Phone 3

[Alexander Koskovich]

On Monday, March 9th, 2026 at 4:34 PM, Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx> wrote:

> > +
> > +&cpu7_opp_table {
> > +	cpu7_opp21: opp-3091200000 {
> > +		opp-hz = /bits/ 64 <3091200000>;
> > +		opp-peak-kBps = <8368000 51609600>;
> > +	};
> 
> I'm a bit concerned about this one, I haven't seen it in the downtream
> SM8250 DT.

Should I leave it out? I tested for a bit and seems like I can boost to this
speed, seemed fine at least.

> > +		qcom,calibration-variant = "ASUS_ROG_Phone_3";
> 
> Just to check, was it submitted upstream?

Yes, though still waiting for it to be picked up:
https://lore.kernel.org/ath11k/PqqPCfIvgme9VLMd4Q91JxMhlc4JOTjuWhwXupf3_0cZXUvRy0wijwNfy7lAY6fiIXHXU_buPPbpDM_Uvht3G26146R4szD7Hvp57m7Totw=@pm.me

> OKay, this answers my earlier question.

Updated the comment in v2, since technically usb_2 does have SS lanes on this
board, they are just not routed to the port I have configured atm.

The board design is a bit special, the HS lanes for the bottom port are sent
to the pogo port when accesories are in use, and then that leaves the bottom
port exclusively for charging. Haven't gotten to modeling that yet, I'm not
sure if there is a way to model that in upstream atm. Would need some USB mux
binding?

Let me know if you would want to see USB 3 re-enabled despite not having a use atm.

> 
> --
> With best wishes
> Dmitry
> 

All other items have been pushed in v2, appreciate the review.

Thanks,
Alex