Re: [PATCH 1/3] dt-bindings: arm: qcom: Add ASUS ROG Phone 3

[Alexander Koskovich]

On Monday, March 9th, 2026 at 3:59 AM, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:

> Please run scripts/checkpatch.pl on the patches and fix reported
> warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
> patches and (probably) fix more warnings. Some warnings can be ignored,
> especially from --strict run, but the code here looks like it needs a
> fix. Feel free to get in touch if the warning is not clear.

Ran checkpatch on v2, got a few warnings that seemed like they could be ignored
given context but let me know if they need to be addressed:

Asked for MAINTAINERS to be updated, but from what I can see there is no other
sm8250 board that has a maintainer specifically listed.

Complained about undocumented tianma,ta066vvhm03 binding, but have that
specified as a dependency in the cover letter so ignored it.

Complained about undocumented pci17cb vendor prefix, but this doesn't seem to
be a vendor name so doesn't seem like warning applies? Also already in
sm8250-xiaomi-elish-common.dtsi.

> Best regards,
> Krzysztof
> 
> 

Thanks,
Alex