Re: [PATCH 1/3] dt-bindings: arm: qcom: Add ASUS ROG Phone 3

[Krzysztof Kozlowski]

On 10/03/2026 04:04, Alexander Koskovich wrote:
> On Monday, March 9th, 2026 at 3:59 AM, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
> 
>> Please run scripts/checkpatch.pl on the patches and fix reported
>> warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
>> patches and (probably) fix more warnings. Some warnings can be ignored,
>> especially from --strict run, but the code here looks like it needs a
>> fix. Feel free to get in touch if the warning is not clear.
> 
> Ran checkpatch on v2, got a few warnings that seemed like they could be ignored
> given context but let me know if they need to be addressed:
> 
> Asked for MAINTAINERS to be updated, but from what I can see there is no other
> sm8250 board that has a maintainer specifically listed.
> 
> Complained about undocumented tianma,ta066vvhm03 binding, but have that
> specified as a dependency in the cover letter so ignored it.

This one. The way you wrote your cover letter does not really makes it
easy to find it. Especially that it's not even true - DTS cannot depend
on drivers.

Clearly document dependencies and new bindings used by DTS. If you are
going to mix these, your patchset will wait and will not be picked up.

Best regards,
Krzysztof