Re: [PATCH v4 1/2] dt-bindings: Input: Add Wacom W9000-series penabled touchscreens
From: Krzysztof Kozlowski
Date: Tue Mar 10 2026 - 13:02:09 EST
On 07/03/2026 19:15, Hendrik Noack wrote:
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + vdd-supply:
> + description:
> + Optional regulator for the VDD digital voltage.
Drop "Optional regulator for"
Also, vdd is mandatory, not optional. How device can work without supply?
> +
> + flash-mode-gpios:
> + maxItems: 1
> + description:
> + Optional GPIO specifier for the touchscreen's flash-mode pin.
Drop "Optional GPIO specifier for the". Don't repeat constraints in free
form text. Schema tells what is optional or what is not. This also
cannot be anything else than GPIO specifier, so repeating obvious is not
making it more readable.
> +
> + pen-inserted-gpios:
> + maxItems: 1
> + description:
> + Optional GPIO specifier for the touchscreen's pen-insert pin.
Drop "Optional GPIO specifier for the".
> +
> + reset-gpios:
> + maxItems: 1
> + description:
> + Optional GPIO specifier for the touchscreen's reset pin.
Drop description completely. Redundant. It cannot be anything else than
reset pin.
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - vdd-supply
Best regards,
Krzysztof