Re: [PATCH v4 1/2] dt-bindings: Input: Add Wacom W9000-series penabled touchscreens
From: Ferass El Hafidi
Date: Tue Mar 10 2026 - 13:11:09 EST
On Tue, 10 Mar 2026 16:55, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
On 10/03/2026 17:50, Ferass El Hafidi wrote:
Hi Krzysztof & Hendrik,
On Mon, 09 Mar 2026 13:21, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
On 09/03/2026 14:12, Hendrik Noack wrote:
Hello Krzysztof,
09.03.2026 13:56:41 Krzysztof Kozlowski <krzk@xxxxxxxxxx>:
On 09/03/2026 13:54, Hendrik Noack wrote:
Hello Krzysztof,
08.03.2026 10:15:35 Krzysztof Kozlowski <krzk@xxxxxxxxxx>:
You received review and instruction what to do. Did you read it?
I read the review of Dmitry and incorporated it into this version.
So you ignored my email completely or it did not reach you (it is on
lore.kernel.org though)?
I don't know what email you mean. You gave reviews on my first verison, which I already incorporated in v2 and then gave a review-by on v2, which I also added on v3, but now dropped, because I added a property
to the DT binding.
The instruction I gave you when giving review.
If you gave review on the v3 dt-bindings, I can't find it on lore:
https://lore.kernel.org/all/20251205152858.14415-2-hendrik-noack@xxxxxx/
On v2 you gave a R-b to the dt-bindings along with some instructions:
https://lore.kernel.org/all/2bf9dbd4-351e-4a79-9fcf-e41c5273d0be@xxxxxxxxxx/
which were followed from what I can tell; your R-b was retained on v3,
but dropped on this revision (v4) because of new properties being added
(new `reset-gpio` property, technically also `wacom,w9002` compatible
but my understanding is new compatibles don't really matter much), as
your email said "Please add Acked-by/Reviewed-by/Tested-by tags when
posting new versions [...] unless patch changed (e.g. new properties
added to the DT bindings)".
Thanks. I also provided the link further explaining what one has to do
if one ever decide to drop the review.
Assuming you're talking about that R-b dropping should be mentioned in
the cover letter, that was probably just overlooked.
Dropping it silently is for me rather sign I should ignore this patchset
to avoid wasting time of lost reviews.
That was most likely not the intent, I think your feedback is valuable.
Best regards,
Ferass
[PS: I see you left some review after your last email, thank you for
your time and sorry for the inconvenience.]
Best regards,
Krzysztof