Re: [PATCH] ASoC: cs35l56: Support clock stop mode 1 if enabled in ACPI

From: Mark Brown

Date: Wed Mar 11 2026 - 12:09:29 EST


On Wed, Mar 11, 2026 at 03:58:35PM +0000, Richard Fitzgerald wrote:
> On 11/03/2026 3:50 pm, Mark Brown wrote:
> > On Wed, Mar 11, 2026 at 03:34:54PM +0000, Richard Fitzgerald wrote:

> > > mipi-sdw-clock-stop-mode1-supported
> > > This optional Boolean Property shall indicate whether or not Clock-stop
> > > is supported on this Device.
> > > Integer (Boolean)
> > > Values:
> > > False (zero): Clock-stop mode1 is not supported on this Device.
> > > True (nonzero): Clock-stop mode1 is supported on this Device.

> > Oh dear, cute enterprise nonsense hacks :(

> The ACPI spec says that each property must be a {key,value} pair.

> If you always need a value there's the possibility that someone will
> create it with value 0 and expect that to mean false. So relying on its
> presence to indicate true is dodgy, safer to define that the value
> has meaning.

But of course we have the default bool operation doing the just check
for presence thing, and probably people looking at that for a good way
to do these things.

Attachment: signature.asc
Description: PGP signature