Re: [PATCH v5 3/6] cpufreq: Centralize boost freq QoS requests

[Rafael J. Wysocki]

On Wed, Feb 25, 2026 at 9:50 AM Pierre Gondois <pierre.gondois@xxxxxxx> wrote:
>
> policy_set_boost() calls the cpufreq set_boost callback.
> Update the newly added boost_freq_req request from there:
> - whenever boost is toggled
> - to cover all possible paths
>
> Signed-off-by: Pierre Gondois <pierre.gondois@xxxxxxx>

I don't quite see a reason for splitting this patch off the previous
one.  Can you combine them into one, please?

> ---
>  drivers/cpufreq/cpufreq.c | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 50467b938668a..42de32488f422 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -603,10 +603,19 @@ static int policy_set_boost(struct cpufreq_policy *policy, bool enable)
>         policy->boost_enabled = enable;
>
>         ret = cpufreq_driver->set_boost(policy, enable);
> -       if (ret)
> +       if (ret) {
>                 policy->boost_enabled = !policy->boost_enabled;
> +               return ret;
> +       }
>
> -       return ret;
> +       ret = freq_qos_update_request(policy->boost_freq_req, policy->cpuinfo.max_freq);
> +       if (ret < 0) {
> +               policy->boost_enabled = !policy->boost_enabled;
> +               cpufreq_driver->set_boost(policy, policy->boost_enabled);
> +               return ret;
> +       }
> +
> +       return 0;
>  }
>
>  static ssize_t store_local_boost(struct cpufreq_policy *policy,
> --
> 2.43.0
>