Re: [PATCH v9 8/8] arm64: dts: add description for solidrun i.mx8mm som and evb

[Josua Mayer]

Am 13.03.26 um 11:01 schrieb Josua Mayer:
> Hi Frank,
>
> Am 09.03.26 um 19:38 schrieb Frank Li:
>> On Thu, Feb 26, 2026 at 06:36:37PM +0200, Josua Mayer wrote:
>>> Add description for the SolidRun i.MX8M Mini SoM on HummingBoard Ripple.
>>>
>>> The SoM features:
>>> - 1Gbps Ethernet with PHY
>>> - eMMC
>>> - 1/2GB DDR
>>> - NPU (assembly option)
>>> - WiFi + Bluetooth
>>>
>>> The HummingBoard Ripple features:
>>> - 2x USB-2.0 Type-A connector
>>> - 1Gbps RJ45 Ethernet with PoE
>>> - microSD connector
>>> - microHDMI connector
>>> - mpcie connector with USB-2.0 interface + SIM card holder
>>> - microUSB connector for console (using fdtdi chip)
>>> - RTC with backup battery
>>>
>>> Signed-off-by: Josua Mayer <josua@xxxxxxxxxxxxx>
>>> ---
>>>  arch/arm64/boot/dts/freescale/Makefile             |   2 +
>>>  .../dts/freescale/imx8mm-hummingboard-ripple.dts   | 335 ++++++++++++++++++
>>>  arch/arm64/boot/dts/freescale/imx8mm-sr-som.dtsi   | 393 +++++++++++++++++++++
>>>  3 files changed, 730 insertions(+)
>> Please run https://github.com/lznuaa/dt-format for new dts(i) files.
>>
>>> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
>>> index a61ed098ff8d..1314aec6634b 100644
>>> --- a/arch/arm64/boot/dts/freescale/Makefile
>>> +++ b/arch/arm64/boot/dts/freescale/Makefile
>>> @@ -126,6 +126,8 @@ imx8mm-evk-pcie-ep-dtbs += imx8mm-evk.dtb imx-pcie0-ep.dtbo
>>>  imx8mm-evkb-pcie-ep-dtbs += imx8mm-evkb.dtb imx-pcie0-ep.dtbo
>>>  dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk-pcie-ep.dtb imx8mm-evkb-pcie-ep.dtb
>>> +
>>> +	carrier_eeprom: eeprom@57{
>> Need space before {, dt-format can fix this for you. patch 1-4 already
>> picked, only need resent 5-8 after run dt-format.
> I tried running the tool again, and it nicely re-ordereed the new imx8mm-hummingboard-ripple.dts
>
> Yet it crashes on imx8mn-solidsense-n8-compact.dts:
>
> ❯ ./dt-format /opt/workspace/linux/arch/arm64/boot/dts/freescale/imx8mn-solidsense-n8-compact.dts
> terminate called after throwing an instance of 'std::out_of_range'
>   what():  basic_string::substr: __pos (which is 26) > this->size() (which is 18)
> [1]    12030 IOT instruction (core dumped)  ./dt-format
&i2c3 {
    /* battery-charger@68 */

    rtc: rtc@69 { };
};

This is what trips it up ... combination of the one line comment, and then an rtc node.
Dropping either the comment, or the rtc node, avoids the crash.

>
> Then I ran it on the iiot board dts and dtso, and it suggests one particular change I was not expecting:
>
> -&{/} {
> +& {};
> +
> +/ {
>
> ❯ find . -iname "*.dtso" -exec grep -H "&{/}" {} \; | wc -l
> 110
>
> ❯ find . -iname "*.dtso" -exec grep -H "/ {" {} \; | wc -l
> 15
>
> Which one is preferred going forward?
>