Re: [PATCH v3 2/2] iio: proximity: add driver for ST VL53L1X ToF sensor
From: Sirat
Date: Fri Mar 13 2026 - 06:59:11 EST
On Fri, Mar 13, 2026 at 3:35 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxx> wrote:
>
> On Thu, Mar 12, 2026 at 11:37:26PM +0600, Sirat wrote:
> > On Thu, Mar 12, 2026 at 8:58 PM Andy Shevchenko
> > <andriy.shevchenko@xxxxxxxxx> wrote:
> > > On Thu, Mar 12, 2026 at 04:40:37AM +0600, Siratul Islam wrote:
>
> ...
> > >
> > > If it's a reset (semantically), use reset-gpio driver and reset APIs here.
> > >
> > The XSHUT pin is a shutdown/enable pin rather than a true reset line,
> > and the existing shared st,vl53l0x.yaml
> > binding already defines it as reset-gpios. So I am keeping the GPIO
> > consumer API here.
>
> And? reset-gpio driver is exactly for those cases. Please, move your driver
> code accordingly.
>
Blame is on me for not realizing that reset controller now also
supports "reset-gpios", my apologies.
My original hesitation was due to not willing to modify the binding to
add "resets"
I will switch to the reset controller.
>
>
Thanks,
Sirat