Re: [PATCH v3 2/2] iio: proximity: add driver for ST VL53L1X ToF sensor

[Jonathan Cameron]

On Thu, 12 Mar 2026 23:37:26 +0600
Sirat <email@xxxxxxxx> wrote:

> On Thu, Mar 12, 2026 at 8:58 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxx> wrote:
> >
> > On Thu, Mar 12, 2026 at 04:40:37AM +0600, Siratul Islam wrote:  
> > > Add support for the STMicroelectronics VL53L1X Time-of-Flight
> > > ranging sensor with I2C interface.  
> > ...
> >  
> > > +static const struct regmap_config vl53l1x_regmap_config = {
> > > +     .reg_bits = 16,
> > > +     .val_bits = 8,  
> >
> > No cache?
> >  
> The result registers change on every measurement, so caching doesn't
> apply well here.
> Will add .cache_type = REGCACHE_NONE  with a comment to clarify.

That's always the case, so more interesting is what registers
don't change? Can just mark the result registers as volatile
and get the advantages from caching the rest.

Someone else may have commented on it already, but please
slow down a bit on sending new versions.  Typically 1 a week
is a reasonable cadence unless things are very near to merge
and you are being asked for minor final tweaks in which case
one every few days is fine.

Jonathan



> > > +};