Re: [PATCH v5 fwctl 4/5] fwctl/bnxt_fwctl: Add bnxt fwctl device

[Pavan Chebbi]

>
> Timeout is such a complicated thing to add to a HW RPC interface. Does
> bnxt do it right? Claude says no, and it looks compelling to me..
>
> So don't give userspace an easy ability to trigger timeout, by
> lowering the timeout value, and causing corruption in the kernel.

Yea I see what you are saying. I think it should be fine if
bnxtctl_fw_rpc() itself increases the timeout for the required
commands.
I can make this change. But if I drop the "timeout" now, I won't need
the driver_data we discussed previously, at least until I actually add
the future enhancements.
So I guess I should defer that change to when I actually use driver_data, right?

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature