Re: [PATCH v5 fwctl 4/5] fwctl/bnxt_fwctl: Add bnxt fwctl device

[Jason Gunthorpe]

On Fri, Mar 13, 2026 at 11:44:05PM +0530, Pavan Chebbi wrote:
> >
> > Timeout is such a complicated thing to add to a HW RPC interface. Does
> > bnxt do it right? Claude says no, and it looks compelling to me..
> >
> > So don't give userspace an easy ability to trigger timeout, by
> > lowering the timeout value, and causing corruption in the kernel.
> 
> Yea I see what you are saying. I think it should be fine if
> bnxtctl_fw_rpc() itself increases the timeout for the required
> commands.

Ah, you wanted to increase the timeout - yes, I think the kernel needs
to do this itself to avoid userspace triggering timeouts that don't
work right..

> I can make this change. But if I drop the "timeout" now, I won't need
> the driver_data we discussed previously, at least until I actually add
> the future enhancements.
> So I guess I should defer that change to when I actually use
> driver_data, right?

Yes all that makes sense. Without timeout and the dma list thing there
is no reason to wrapper the commands. Comme with some driver_data
later if you find you need more info

Jason