Re: [PATCH] ALSA: usb-audio: use kzalloc_flex

[Takashi Iwai]

On Fri, 13 Mar 2026 23:02:08 +0100,
Rosen Penev wrote:
> 
> On Wed, Mar 11, 2026 at 11:45 PM Rosen Penev <rosenp@xxxxxxxxx> wrote:
> >
> > On Wed, Mar 11, 2026 at 11:34 PM Takashi Iwai <tiwai@xxxxxxx> wrote:
> > >
> > > On Thu, 12 Mar 2026 00:27:48 +0100,
> > > Rosen Penev wrote:
> > > >
> > > > Saves one allocation by using a flexible array member.
> > >
> > > As it's a fixed size array, it doesn't have to be a flex array at all,
> > > so it can be even simpler.
> > That's true. The comment even admits as such. Wonder why it was ever a
> > pointer allocated with calloc...
> Oh no I see the issue:
> 
> sound/usb/mixer.c:#define MAX_ID_ELEMS  256
> 
> I don't think this is supposed to be in the header.

Why?


Takashi