Re: [PATCH v2 1/2] Revert "ALSA: hda/realtek: Fix speaker pop on Star Labs StarFighter"

[Takashi Iwai]

On Thu, 12 Mar 2026 13:20:20 +0100,
Sean Rhodes wrote:
> 
> The shutup delay workaround fixes the runtime suspend pop, but further
> hardware testing showed that the StarFighter speaker path can be
> controlled more directly.
> 
> The ALC233 speaker path uses LINE2 EAPD on NID 0x1b together with GPIO2
> for the external speaker amplifier, so a better fix is to sequence those
> controls at playback start and stop instead of sleeping in the shutup
> callback.
> 
> Revert the previous workaround before adding the runtime sequencing fix.
> 
> This reverts commit 1cb3c20688fc8380c9b365d03aea7e84faf6a9fd.
> 
> Cc: Jaroslav Kysela <perex@xxxxxxxx>
> Cc: Takashi Iwai <tiwai@xxxxxxxx>
> Cc: Stefan Binding <sbinding@xxxxxxxxxxxxxxxxxxxxx>
> Cc: Kailang Yang <kailang@xxxxxxxxxxx>
> Cc: Chris Chiu <chris.chiu@xxxxxxxxxxxxx>
> Cc: Edip Hazuri <edip@xxxxxxxxx>
> Cc: linux-sound@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Signed-off-by: Sean Rhodes <sean@starlabs.systems>

I don't think we need two steps, but rather fold your update into a
single patch (but give Fixes tag).  It's a change only for a single
device and model, after all.


thanks,

Takashi