Re: [PATCH v3] staging: rtl8723bs: remove dead code
From: Dan Carpenter
Date: Wed Mar 18 2026 - 07:18:12 EST
On Wed, Mar 18, 2026 at 04:13:31PM +0530, Aadarsh Mandal wrote:
> remove unused and commented code
> no changes in functionality
Line wrap at 74 characters. Add a period to the end of the sentence.
>
> Signed-off-by: Aadarsh Mandal <aadarshmandal9354@xxxxxxxxx>
> ---
> v3:
> - regenrated patch from the clean tree
> - removed unwanted addition
> v2:
> - accidently added the functions in the {} blocks
> v1:
> - some commented code wasnt deleted.
> Note:
> * This patch is part of the GSoC2026 application process for device tree bindings conversions
> * https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device-Tree-Bindings
>
> drivers/staging/rtl8723bs/hal/sdio_halinit.c | 21 ++++++--------------
> 1 file changed, 6 insertions(+), 15 deletions(-)
It should only be deletions and 0 insertions. Review the patch
and run checkpatch.pl on it before sending.
regards,
dan carpenter