Re: [PATCH v3] staging: rtl8723bs: remove dead code
From: Dan Carpenter
Date: Wed Mar 18 2026 - 07:34:34 EST
On Wed, Mar 18, 2026 at 02:17:58PM +0300, Dan Carpenter wrote:
> On Wed, Mar 18, 2026 at 04:13:31PM +0530, Aadarsh Mandal wrote:
> > remove unused and commented code
> > no changes in functionality
>
> Line wrap at 74 characters. Add a period to the end of the sentence.
>
Also use capital letters at the start of a sentence.
Remove unused and commented code. No changes in functionality.
Probably saying "No changes in functionality." is not really necessary
because it's obvious. Where it's more important is with things like
changing strcpy() to strcpy() which could look like a bugfix. But it's
fine to add that. We would have accepted it either way.
Wait a day between resends.
regards,
dan carpenter