Re: [PATCH v5 3/9] clk: renesas: r9a07g04{3,4}/r9a08g045-cpg: Add critical reset entries

[Geert Uytterhoeven]

Hi Biju,

On Wed, 18 Mar 2026 at 09:42, Biju <biju.das.au@xxxxxxxxx> wrote:
> From: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
>
> The RZ/G2L SoC family requires DMA resets to be deasserted for routing
> some peripheral interrupts to the CPU. Asserting these resets after boot
> would silently break interrupt delivery with no driver to restore them.
>
> Mark the DMA resets as critical by adding them to the crit_resets table
> in the SoC-specific rzg2l_cpg_info for r9a07g043, r9a07g044, and
> r9a08g045, preventing __rzg2l_cpg_assert() from asserting them and
> ensuring they are deasserted during probe and resume.
>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>

Thanks for your patch!

> --- a/drivers/clk/renesas/r9a07g043-cpg.c
> +++ b/drivers/clk/renesas/r9a07g043-cpg.c
> @@ -379,6 +379,11 @@ static const unsigned int r9a07g043_crit_mod_clks[] __initconst = {
>         MOD_CLK_BASE + R9A07G043_DMAC_ACLK,
>  };
>
> +static const unsigned int r9a07g043_critical_resets[] = {

"r9a07g043_crit_resets", for consistency with ".crit_resets" (everywhere).


> +       R9A07G043_DMAC_ARESETN,
> +       R9A07G043_DMAC_RST_ASYNC,
> +};
> +
>  #ifdef CONFIG_ARM64
>  static const unsigned int r9a07g043_no_pm_mod_clks[] = {
>         MOD_CLK_BASE + R9A07G043_CRU_SYSCLK,
> @@ -420,5 +425,8 @@ const struct rzg2l_cpg_info r9a07g043_cpg_info = {
>         .num_resets = R9A07G043_IAX45_RESETN + 1, /* Last reset ID + 1 */
>  #endif
>
> +       /* Critical Resets */
> +       .crit_resets = r9a07g043_critical_resets,
> +       .num_crit_resets = ARRAY_SIZE(r9a07g043_critical_resets),
>         .has_clk_mon_regs = true,
>  };

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds