Re: [PATCH] staging: rtl8723bs: tidy logical continuations in xmit_linux.c

[Andy Shevchenko]

On Tue, Mar 24, 2026 at 12:45:01AM +0530, sajal90 wrote:

This is NOT how the patches should be formed.
Your homework:

- read and study Submitting Patches documentation
https://www.kernel.org/doc/html/latest/process/submitting-patches.html

- read this
https://chris.beams.io/git-commit

> ---
>  drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 11 +++++------

...

> -	if (!rtw_mc2u_disable
> -		&& check_fwstate(pmlmepriv, WIFI_AP_STATE) == true
> -		&& (IP_MCAST_MAC(pkt->data)
> -			|| ICMPV6_MCAST_MAC(pkt->data)
> -			)
> -		&& padapter->registrypriv.wifi_spec == 0) {
> +	if (!rtw_mc2u_disable &&
> +		check_fwstate(pmlmepriv, WIFI_AP_STATE) == true &&
> +		(IP_MCAST_MAC(pkt->data) ||
> +		 ICMPV6_MCAST_MAC(pkt->data)) &&
> +		padapter->registrypriv.wifi_spec == 0) {

This isn't correct, fix the indentation and the logical splits
(less lines can be made).

-- 
With Best Regards,
Andy Shevchenko