Re: [PATCH] staging: rtl8723bs: tidy logical continuations in xmit_linux.c

[Andy Shevchenko]

On Mon, Mar 23, 2026 at 09:47:42PM -0500, Ethan Tidmore wrote:
> On Mon Mar 23, 2026 at 2:15 PM CDT, sajal90 wrote:

...

>  You fixed the logical continuation problem but the alignment is still
>  wrong. It should be something like:
> 
> 	if (!rtw_mc2u_disable &&
> 	    check_fwstate(pmlmepriv, WIFI_AP_STATE) &&

Why not

	if (!rtw_mc2u_disable && check_fwstate(pmlmepriv, WIFI_AP_STATE) &&

?

> 	    (IP_MCAST_MAC(pkt->data) || 
> 	     ICMPV6_MCAST_MAC(pkt->data)) &&

This also can be joined as it's logically a one piece of the conditional.

	    (IP_MCAST_MAC(pkt->data) || ICMPV6_MCAST_MAC(pkt->data)) &&

> 	    !padapter->registrypriv.wifi_spec) {

-- 
With Best Regards,
Andy Shevchenko