Re: [PATCH v2 3/3] lib: kunit_iov_iter: Add tests for extract_iter_to_sg

From: David Howells

Date: Tue Mar 24 2026 - 19:16:41 EST


Josh Law <objecting@xxxxxxxxxxxxx> wrote:

> if (memcmp(data->buffer, data->scratch, bufsize)) {

If you do this, please do "memcmp(...) != 0". It's not a boolean function and
the sense is effectively inverted.

David