Re: [PATCH v2 3/3] lib: kunit_iov_iter: Add tests for extract_iter_to_sg

From: Josh Law

Date: Tue Mar 24 2026 - 19:18:08 EST




On 24 March 2026 23:14:31 GMT, David Howells <dhowells@xxxxxxxxxx> wrote:
>Josh Law <objecting@xxxxxxxxxxxxx> wrote:
>
>> if (memcmp(data->buffer, data->scratch, bufsize)) {
>
>If you do this, please do "memcmp(...) != 0". It's not a boolean function and
>the sense is effectively inverted.
>
>David
>


Oh yeah, good catch. My mistake

Yeah, David is right


V/R


Josh Law