Re: [PATCH v2 1/3] lib: kunit_iov_iter: Improve error detection

From: David Howells

Date: Tue Mar 24 2026 - 19:19:15 EST


Josh Law <objecting@xxxxxxxxxxxxx> wrote:

> >+ unsigned int i;
>
> Nit: unsigned long is probably better here

Why?

> >+ for (i = 0; i < npages / 4; ++i)

I would suggest putting the type here:

for (int i = 0; ...)

sort of thing.

David