Re: [PATCH v2 1/3] lib: kunit_iov_iter: Improve error detection

[Josh Law]

On 24 March 2026 23:18:49 GMT, David Howells <dhowells@xxxxxxxxxx> wrote:
>Josh Law <objecting@xxxxxxxxxxxxx> wrote:
>
>> >+	unsigned int i;
>> 
>> Nit: unsigned long is probably better here
>
>Why?
>
>> >+	for (i = 0; i < npages / 4; ++i)
>
>I would suggest putting the type here:
>
>	for (int i = 0; ...)
>
>sort of thing.
>
>David
>


Hmmm. You declare unsigned int i; but the total number of pages (npages) and the got counter are usually unsigned long in this context. But its a small nit, nothing that changes my opinion on this being merged :-)


V/R


Josh Law