[PATCH] mm/damon/sysfs: dealloc repeat_call_control if damon_call() fails

From: SeongJae Park

Date: Thu Mar 26 2026 - 20:32:38 EST


damon_call() for repeat_call_control of DAMON_SYSFS could fail if
somehow the kdamond is stopped before the damon_call(). It could
happen, for example, when te damon context was made for monitroing of a
virtual address processes, and the process is terminated immediately,
before the damon_call() invocation. In the case, the dyanmically
allocated repeat_call_control is not deallocated and leaked.

Fix the leak by deallocating the repeat_call_control under the
damon_call() failure.

This issue is discovered by sashiko [1].

[1] https://lore.kernel.org/20260320020630.962-1-sj@xxxxxxxxxx

Fixes: 04a06b139ec0 ("mm/damon/sysfs: use dynamically allocated repeat mode damon_call_control")
Cc: <stable@xxxxxxxxxxxxxxx> # 6.17.x
Signed-off-by: SeongJae Park <sj@xxxxxxxxxx>
---
Changes from RFC
(https://lore.kernel.org/20260326062347.88569-2-sj@xxxxxxxxxx)
- Split out from the series.
- Drop RFC tag.
- Add Fixes: and Cc: stable.

mm/damon/sysfs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c
index 6a44a2f3d8fc..eefa959aa30a 100644
--- a/mm/damon/sysfs.c
+++ b/mm/damon/sysfs.c
@@ -1670,7 +1670,8 @@ static int damon_sysfs_turn_damon_on(struct damon_sysfs_kdamond *kdamond)
repeat_call_control->data = kdamond;
repeat_call_control->repeat = true;
repeat_call_control->dealloc_on_cancel = true;
- damon_call(ctx, repeat_call_control);
+ if (damon_call(ctx, repeat_call_control))
+ kfree(repeat_call_control);
return err;
}


base-commit: dd478b2be41492a9f7be5abbdbd4dceddc46818f
--
2.47.3