Re: [PATCH v6] staging: media: atomisp: fix GP_TIMER_BASE scope in gp_timer.c

[Anushka B]

On Fri, Mar 27, 2026 at 3:13 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxx> wrote:
>
> On Fri, Mar 27, 2026 at 08:41:06AM +0530, Anushka Badhe wrote:
> > GP_TIMER_BASE is only used in gp_timer.c and it does not need to be
> > globally visible.
> >
> > Move its declaration from system_local.c to gp_timer.c and make it file
> > local by marking it static. Remove external declaration from system_local.h
> > and its usage in gp_timer.h
> >
> > This fixes a sparse warning about global visibility and cleans up
> > unnecessary global exposure.
>
> ...
>
> > ---
> > Changes in v6:
> > - Mark scope of GP_TIMER_BASE static
>
> Good catch, but read my comment against v5. And slow down with new versions,
> no new version within 24h, please!
>
> --
> With Best Regards,
> Andy Shevchenko
>

Hi Andy,
I saw your comment on v5 regarding the GP TIMER comment style, thank
you for the example.
I also received feedback from Sakari on this file:
> Please don't move the defition here. There's a reason for keeping it in the
> same location with the rest of the offsets.
Would it be acceptable to go back to the simpler in-place merge in
system_local.c, joining the split
declaration of GP_TIMER_BASE? I can follow up with the comment
formatting as a separate patch.

I'll make sure to discuss changes before sending new revisions going forward.

Thank you,
Anushka