Re: [PATCH v6] staging: media: atomisp: fix GP_TIMER_BASE scope in gp_timer.c

[Andy Shevchenko]

On Mon, Mar 30, 2026 at 4:19 AM Anushka B <anushkabadhe@xxxxxxxxx> wrote:
> On Fri, Mar 27, 2026 at 3:13 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxx> wrote:
> > On Fri, Mar 27, 2026 at 08:41:06AM +0530, Anushka Badhe wrote:

...

> > > ---
> > > Changes in v6:
> > > - Mark scope of GP_TIMER_BASE static
> >
> > Good catch, but read my comment against v5. And slow down with new versions,
> > no new version within 24h, please!

> I saw your comment on v5 regarding the GP TIMER comment style, thank
> you for the example.
> I also received feedback from Sakari on this file:
> > Please don't move the defition here. There's a reason for keeping it in the
> > same location with the rest of the offsets.
> Would it be acceptable to go back to the simpler in-place merge in
> system_local.c, joining the split
> declaration of GP_TIMER_BASE? I can follow up with the comment
> formatting as a separate patch.

Sakari is the maintainer, follow what he says.

-- 
With Best Regards,
Andy Shevchenko