Re: [PATCH v3 1/3] dt-bindings: clock: amlogic: Fix redundant hyphen in "amlogic,t7-gp1--pll" string.

[Jian Hu]

On 3/27/2026 3:23 PM, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
>
> On Thu, Mar 26, 2026 at 05:26:43PM +0800, Jian Hu wrote:
> > Fix redundant hyphen in "amlogic,t7-gp1--pll" string.
> >
> > Fixes: 5437753728ac ("dt-bindings: clock: add Amlogic T7 PLL clock controller")
> Please run scripts/checkpatch.pl on the patches and fix reported
> warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
> patches and (probably) fix more warnings. Some warnings can be ignored,
> especially from --strict run, but the code here looks like it needs a
> fix. Feel free to get in touch if the warning is not clear.


Thanks for your review.


This series is based on the clk-next branch (version v7.0-rc1).


Here are the check results without --strict:


$ ./scripts/checkpatch.pl 
0001-dt-bindings-clock-amlogic-Fix-redundant-hyphen-in-am.patch
total: 0 errors, 0 warnings, 8 lines checked

0001-dt-bindings-clock-amlogic-Fix-redundant-hyphen-in-am.patch has no 
obvious style problems and is ready for submission.

$ ./scripts/checkpatch.pl 
0002-dt-bindings-clock-amlogic-t7-Add-missing-mpll3-paren.patch
total: 0 errors, 0 warnings, 46 lines checked

0002-dt-bindings-clock-amlogic-t7-Add-missing-mpll3-paren.patch has no 
obvious style problems and is ready for submission.

$ ./scripts/checkpatch.pl 
0003-arm64-dts-amlogic-t7-Add-clock-controller-nodes.patch
total: 0 errors, 0 warnings, 149 lines checked


Here are the check results with --strict (I had also checked them with 
this script before submitting these patches):


$ ./scripts/checkpatch.pl --strict 
0001-dt-bindings-clock-amlogic-Fix-redundant-hyphen-in-am.patch
total: 0 errors, 0 warnings, 0 checks, 8 lines checked

0001-dt-bindings-clock-amlogic-Fix-redundant-hyphen-in-am.patch has no 
obvious style problems and is ready for submission.

$ ./scripts/checkpatch.pl --strict 
0002-dt-bindings-clock-amlogic-t7-Add-missing-mpll3-paren.patch
total: 0 errors, 0 warnings, 0 checks, 46 lines checked

0002-dt-bindings-clock-amlogic-t7-Add-missing-mpll3-paren.patch has no 
obvious style problems and is ready for submission.

$ ./scripts/checkpatch.pl --strict 
0003-arm64-dts-amlogic-t7-Add-clock-controller-nodes.patch
total: 0 errors, 0 warnings, 0 checks, 149 lines checked

0003-arm64-dts-amlogic-t7-Add-clock-controller-nodes.patch has no 
obvious style problems and is ready for submission.


I have also run the script on the latest v7.0-rc5,  and no warnings are 
reported.


Could you tell me which version of the checkpatch script you are using?

If you are using a locally modified script, kindly let me know which 
warnings I need to fix.

> > Signed-off-by: Ronald Claveau <linux-kernel-dev@xxxxxxxx>
> > Signed-off-by: Jian Hu <jian.hu@xxxxxxxxxxx>
> Best regards,
> Krzysztof