Re: [PATCH v3 1/3] dt-bindings: clock: amlogic: Fix redundant hyphen in "amlogic,t7-gp1--pll" string.

From: Krzysztof Kozlowski

Date: Mon Mar 30 2026 - 06:57:14 EST


On 30/03/2026 12:44, Jian Hu wrote:
>
> On 3/27/2026 3:23 PM, Krzysztof Kozlowski wrote:
>> [ EXTERNAL EMAIL ]
>>
>> On Thu, Mar 26, 2026 at 05:26:43PM +0800, Jian Hu wrote:
>>> Fix redundant hyphen in "amlogic,t7-gp1--pll" string.
>>>
>>> Fixes: 5437753728ac ("dt-bindings: clock: add Amlogic T7 PLL clock controller")
>> Please run scripts/checkpatch.pl on the patches and fix reported
>> warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
>> patches and (probably) fix more warnings. Some warnings can be ignored,
>> especially from --strict run, but the code here looks like it needs a
>> fix. Feel free to get in touch if the warning is not clear.
>
>
> Thanks for your review.
>
>
> This series is based on the clk-next branch (version v7.0-rc1).
>
>
> Here are the check results without --strict:
>

I checked before. Now I double checked:

b4 shazam...
git format-patch -3
scripts/checkpatch.pl 0*

Clearly a warning, also on v7.0-rc1.

So maybe you don't do it on the kernel you are claiming or just doing it
on different code than you sent.

Especially the second case would be a waste of my time to investigate
and read this patch.

Best regards,
Krzysztof