Re: [PATCH v3 01/15] userfaultfd: introduce mfill_copy_folio_locked() helper

From: Harry Yoo (Oracle)

Date: Mon Mar 30 2026 - 23:34:19 EST


On Mon, Mar 30, 2026 at 01:11:02PM +0300, Mike Rapoport wrote:
> From: "Mike Rapoport (Microsoft)" <rppt@xxxxxxxxxx>
>
> Split copying of data when locks held from mfill_atomic_pte_copy() into a
> helper function mfill_copy_folio_locked().
>
> This makes improves code readability and makes complex
> mfill_atomic_pte_copy() function easier to comprehend.
>
> No functional change.
>
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@xxxxxxxxxx>
> Acked-by: Peter Xu <peterx@xxxxxxxxxx>
> Reviewed-by: David Hildenbrand (Arm) <david@xxxxxxxxxx>
> ---

Looks good to me,
Reviewed-by: Harry Yoo (Oracle) <harry@xxxxxxxxxx>

--
Cheers,
Harry / Hyeonggon