Re: [PATCH] riscv: signal: refactor debug logging to use macros

[Michael Ellerman]

On 30/3/2026 15:34, Austin Kim wrote:
> From: Austin Kim <austin.kim@xxxxxxx>
>
> Replace manual #if DEBUG_SIG blocks with a unified DEBUGP macro.
> This will improve code readability.
>
> Signed-off-by: Austin Kim <austin.kim@xxxxxxx>
> ---
>   arch/riscv/kernel/compat_signal.c | 10 ++++++----
>   arch/riscv/kernel/signal.c        | 10 ++++++----
>   2 files changed, 12 insertions(+), 8 deletions(-)
>
> diff --git a/arch/riscv/kernel/compat_signal.c b/arch/riscv/kernel/compat_signal.c
> index 6ec4e3425..c82235be7 100644
> --- a/arch/riscv/kernel/compat_signal.c
> +++ b/arch/riscv/kernel/compat_signal.c
> @@ -12,7 +12,11 @@
>   #include <asm/ucontext.h>
>   #include <asm/vdso.h>
>   
> -#define COMPAT_DEBUG_SIG 0
> +#ifdef DEBUG_SIG
> +#  define DEBUGP(fmt, args...) pr_info("%s: " fmt, __func__, ##args)
> +#else
> +#  define DEBUGP(fmt, args...)
> +#endif
>   
>   struct compat_sigcontext {
>   	struct compat_user_regs_struct sc_regs;
> @@ -233,11 +237,9 @@ int compat_setup_rt_frame(struct ksignal *ksig, sigset_t *set,
>   	regs->a1 = (unsigned long)(&frame->info); /* a1: siginfo pointer */
>   	regs->a2 = (unsigned long)(&frame->uc);   /* a2: ucontext pointer */
>   
> -#if COMPAT_DEBUG_SIG
> -	pr_info("SIG deliver (%s:%d): sig=%d pc=%p ra=%p sp=%p\n",
> +	DEBUGP("SIG deliver (%s:%d): sig=%d pc=%p ra=%p sp=%p\n",
>   		current->comm, task_pid_nr(current), ksig->sig,
>   		(void *)regs->epc, (void *)regs->ra, frame);
> -#endif
>   
>   	return 0;
>   }
Is there any reason not to use pr_devel()?

Or pr_debug() if enabling it at runtime is desirable (with 
CONFIG_DYNAMIC_DEBUG=y).

cheers