RE: [PATCH 0/2] Add Renesas RZ/G3L RSPI support
From: Biju Das
Date: Thu Apr 02 2026 - 11:18:16 EST
Hi Mark,
Thanks for the feedback.
> -----Original Message-----
> From: Mark Brown <broonie@xxxxxxxxxx>
> Sent: 02 April 2026 15:52
> Subject: Re: [PATCH 0/2] Add Renesas RZ/G3L RSPI support
>
> On Thu, Apr 02, 2026 at 01:32:29PM +0000, Biju Das wrote:
> > > -----Original Message-----
> > > From: Mark Brown <broonie@xxxxxxxxxx>
> > > Sent: 02 April 2026 14:20
> > > Subject: Re: [PATCH 0/2] Add Renesas RZ/G3L RSPI support
> > >
> > > On Thu, Apr 02, 2026 at 01:00:28PM +0000, Biju Das wrote:
>
> > > > Gentle ping.
>
> > > There's strongly negative feedback from Krzysztof...
>
> > I believe Krzysztof is complaining about patch [1] and his comments
> > were addressed in [2].
>
> That's really not at all clear from the discussion.
>
> Please include human readable descriptions of things like commits and issues being discussed in e-mail
> in your mails, this makes them much easier for humans to read especially when they have no internet
> access.
> I do frequently catch up on my mail on flights or while otherwise travelling so this is even more
> pressing for me than just being about making things a bit easier to read.
Agreed.
>
> > > Please don't send content free pings and please allow a reasonable
> > > time for review. People get busy, go on holiday, attend conferences
> > > and so on so unless there is some reason for urgency (like critical
> > > bug fixes) please allow at least a couple of weeks for review. If there have been review comments
> then people may be waiting for those to be addressed.
>
> > > Sending content free pings adds to the mail volume (if they are seen
> > > at
> > > all) which is often the problem and since they can't be reviewed
> > > directly if something has gone wrong you'll have to resend the
> > > patches anyway, so sending again is generally a better approach
> > > though there are some other maintainers who like them - if in doubt look at how patches for the
> subsystem are normally handled.
>
> > There is no pending points, everything addressed in [2]. that is the
> > reason for sending gentle reminder.
>
> There's more there than just "make sure you've addressed review comments".
The issues related to flexible DMA names for multiple DMAs are addressed by the
commit c2edd7841f58 ("spi: dt-bindings: renesas,rzv2h-rspi: Document dmas property").
It looks like Krzysztof wants strict ordering in bindings for DMA names, if it is
a single DMA.
I will wait for his feedback.
Cheers,
Biju