Re: [PATCH 1/3] [v4, net-next] net: ethernet: ti-cpsw:: rename soft_reset() function

[Ilias Apalodimas]

Hi Arnd,

On Thu, 2 Apr 2026 at 21:47, Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
>
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> While looking at the glob symbols shared between the cpsw drivers,
> I noticed that soft_reset() is the only one that is missing a proper
> namespace prefix, and will pollute the kernel namespace, so rename
> it to be consistent with the other symbols.
>
> Fixes: c5013ac1dd0e1 ("net: ethernet: ti: cpsw: move set of common functions in cpsw_priv")

The patch seems fine, but why the Fixes: tag?

Cheers
/Ilias
> Reviewed-by: Alexander Sverdlin <alexander.sverdlin@xxxxxxxxx>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
>  drivers/net/ethernet/ti/cpsw.c      | 2 +-
>  drivers/net/ethernet/ti/cpsw_new.c  | 2 +-
>  drivers/net/ethernet/ti/cpsw_priv.c | 2 +-
>  drivers/net/ethernet/ti/cpsw_priv.h | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
> index b0e18bdc2c85..aa3531e844e8 100644
> --- a/drivers/net/ethernet/ti/cpsw.c
> +++ b/drivers/net/ethernet/ti/cpsw.c
> @@ -706,7 +706,7 @@ static void cpsw_init_host_port(struct cpsw_priv *priv)
>         struct cpsw_common *cpsw = priv->cpsw;
>
>         /* soft reset the controller and initialize ale */
> -       soft_reset("cpsw", &cpsw->regs->soft_reset);
> +       cpsw_soft_reset("cpsw", &cpsw->regs->soft_reset);
>         cpsw_ale_start(cpsw->ale);
>
>         /* switch to vlan aware mode */
> diff --git a/drivers/net/ethernet/ti/cpsw_new.c b/drivers/net/ethernet/ti/cpsw_new.c
> index 7f42f58a4b03..c5be359f3c66 100644
> --- a/drivers/net/ethernet/ti/cpsw_new.c
> +++ b/drivers/net/ethernet/ti/cpsw_new.c
> @@ -573,7 +573,7 @@ static void cpsw_init_host_port(struct cpsw_priv *priv)
>         u32 control_reg;
>
>         /* soft reset the controller and initialize ale */
> -       soft_reset("cpsw", &cpsw->regs->soft_reset);
> +       cpsw_soft_reset("cpsw", &cpsw->regs->soft_reset);
>         cpsw_ale_start(cpsw->ale);
>
>         /* switch to vlan aware mode */
> diff --git a/drivers/net/ethernet/ti/cpsw_priv.c b/drivers/net/ethernet/ti/cpsw_priv.c
> index bc4fdf17a99e..c6eb6b785b0b 100644
> --- a/drivers/net/ethernet/ti/cpsw_priv.c
> +++ b/drivers/net/ethernet/ti/cpsw_priv.c
> @@ -275,7 +275,7 @@ void cpsw_set_slave_mac(struct cpsw_slave *slave, struct cpsw_priv *priv)
>         slave_write(slave, mac_lo(priv->mac_addr), SA_LO);
>  }
>
> -void soft_reset(const char *module, void __iomem *reg)
> +void cpsw_soft_reset(const char *module, void __iomem *reg)
>  {
>         unsigned long timeout = jiffies + HZ;
>
> diff --git a/drivers/net/ethernet/ti/cpsw_priv.h b/drivers/net/ethernet/ti/cpsw_priv.h
> index acb6181c5c9e..fddd7a79f4b0 100644
> --- a/drivers/net/ethernet/ti/cpsw_priv.h
> +++ b/drivers/net/ethernet/ti/cpsw_priv.h
> @@ -458,7 +458,7 @@ int cpsw_tx_poll(struct napi_struct *napi_tx, int budget);
>  int cpsw_rx_mq_poll(struct napi_struct *napi_rx, int budget);
>  int cpsw_rx_poll(struct napi_struct *napi_rx, int budget);
>  void cpsw_rx_vlan_encap(struct sk_buff *skb);
> -void soft_reset(const char *module, void __iomem *reg);
> +void cpsw_soft_reset(const char *module, void __iomem *reg);
>  void cpsw_set_slave_mac(struct cpsw_slave *slave, struct cpsw_priv *priv);
>  void cpsw_ndo_tx_timeout(struct net_device *ndev, unsigned int txqueue);
>  int cpsw_need_resplit(struct cpsw_common *cpsw);
> --
> 2.39.5
>