Re: [PATCH 1/3] [v4, net-next] net: ethernet: ti-cpsw:: rename soft_reset() function

[Arnd Bergmann]

On Thu, Apr 2, 2026, at 21:13, Ilias Apalodimas wrote:
> Hi Arnd,
>
> On Thu, 2 Apr 2026 at 21:47, Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
>>
>> From: Arnd Bergmann <arnd@xxxxxxxx>
>>
>> While looking at the glob symbols shared between the cpsw drivers,
>> I noticed that soft_reset() is the only one that is missing a proper
>> namespace prefix, and will pollute the kernel namespace, so rename
>> it to be consistent with the other symbols.
>>
>> Fixes: c5013ac1dd0e1 ("net: ethernet: ti: cpsw: move set of common functions in cpsw_priv")
>
> The patch seems fine, but why the Fixes: tag?

Before the c5013ac1dd0e1 commit, this was a 'static inline' function,
which is allowed to clash with other identifiers. Making it a global
symbol during the move was a problem.

       Arnd