Re: [RFC PATCH 1/5] pci_ids: Add Hygon Family 0x18 DF device IDs

[Lin Wang]

Hi Mario,

On 4/3/2026 1:56 AM, Mario Limonciello wrote:

> I don't think this is a good idea to start precedent of using exact same 
> define for Hygon and AMD because it might not always be true.
>
> Could we instead have something like
>
> #define PCI_DEVICE_ID_HYGON_17H_M30H_DF_F3 PCI_DEVICE_ID_AMD_17H_M30H_DF_F3
>
> And then anywhere you're using it like you describe (such as how I see 
> in patch 3) then you can use PCI_DEVICE_ID_HYGON_17H_M30H_DF_F3 instead.

Agreed, thank you for the clear guidance.

In v2, all Hygon device IDs will be defined with explicit values in the 
Hygon section of pci_ids.h, with no reference to any AMD defines.

Specifically:

- The two AMD F4 IDs added in patch 1 (PCI_DEVICE_ID_AMD_17H_DF_F4 and 
PCI_DEVICE_ID_AMD_17H_M30H_DF_F4) will be removed; they were added 
solely because Hygon code needed those values.

- Four new Hygon defines will replace the AMD-prefixed IDs currently 
used in patch 3's PCI_DEVICE() tables:
        PCI_DEVICE_ID_HYGON_18H_M04H_DF_F3   0x1463
        PCI_DEVICE_ID_HYGON_18H_M04H_DF_F3B  0x1493
        PCI_DEVICE_ID_HYGON_18H_M04H_DF_F4   0x1464
        PCI_DEVICE_ID_HYGON_18H_M04H_DF_F4B  0x1494

Thx & Br,

Lin