Re: [PATCH v1] ASoC: codecs: wcd937x: Add conditional regulator control for wcd937x

[Karthik S]

Hi @Krzysztof,

On 4/2/2026 12:43 PM, Krzysztof Kozlowski wrote:
> On 02/04/2026 09:08, karthik.s wrote:
> > Add has_always_on_supplies for managing regulators. Indicates that
> > the codec supply regulators are always enabled by the system and
> > must not be requested or enabled by the codec driver.
> >
> > Signed-off-by: karthik.s<karthik.s@xxxxxxxxxxxxxxxx>
> Please configure your Git.

I have configured Git as you suggested :
user.name = Karthik S
user.email = karthik.s@xxxxxxxxxxxxxxxx

> > ---
> >   .../devicetree/bindings/sound/qcom,wcd937x.yaml     |  6 ++++++
> >   sound/soc/codecs/wcd937x.c                          | 13 +++++++++----
> Please run scripts/checkpatch.pl on the patches and fix reported
> warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
> patches and (probably) fix more warnings. Some warnings can be ignored,
> especially from --strict run, but the code here looks like it needs a
> fix. Feel free to get in touch if the warning is not clear.

I have run the scripts/checkpatch.pl and fixed all warnings/errors 
indicated.


> >   2 files changed, 15 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd937x.yaml b/Documentation/devicetree/bindings/sound/qcom,wcd937x.yaml
> > index f94203798f24..d89fff1f7171 100644
> > --- a/Documentation/devicetree/bindings/sound/qcom,wcd937x.yaml
> > +++ b/Documentation/devicetree/bindings/sound/qcom,wcd937x.yaml
> > @@ -28,6 +28,12 @@ properties:
> >     vdd-px-supply:
> >       description: A reference to the 1.8V I/O supply
> >   
> > +  qcom,always-on-supply:
> You described the desired Linux feature or behavior, not the actual
> hardware. The bindings are about the latter, so instead you need to
> rephrase the property and its description to match actual hardware
> capabilities/features/configuration etc.

Current description in dt-binding:
Indicates that the codec supply regulators are always enabled by the 
system and must not be requested or enabled by the codec driver.

new description in dt-binding:
implies that the codec supply Vdd is on always on rails off the 
board/hardware and must not be requested or enabled by the codec driver.

please let us know if you are okay with above changes

Thanks and Regards,
Karthik S