Re: [PATCH v1] ASoC: codecs: wcd937x: Add conditional regulator control for wcd937x

[Krzysztof Kozlowski]

On 10/04/2026 07:38, Karthik S wrote:
>>>
>>> diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd937x.yaml b/Documentation/devicetree/bindings/sound/qcom,wcd937x.yaml
>>> index f94203798f24..d89fff1f7171 100644
>>> --- a/Documentation/devicetree/bindings/sound/qcom,wcd937x.yaml
>>> +++ b/Documentation/devicetree/bindings/sound/qcom,wcd937x.yaml
>>> @@ -28,6 +28,12 @@ properties:
>>>     vdd-px-supply:
>>>       description: A reference to the 1.8V I/O supply
>>>   
>>> +  qcom,always-on-supply:
>> You described the desired Linux feature or behavior, not the actual
>> hardware. The bindings are about the latter, so instead you need to
>> rephrase the property and its description to match actual hardware
>> capabilities/features/configuration etc.
> 
> Current description in dt-binding:
> Indicates that the codec supply regulators are always enabled by the 
> system and must not be requested or enabled by the codec driver.
> 
> new description in dt-binding:
> implies that the codec supply Vdd is on always on rails off the 
> board/hardware and must not be requested or enabled by the codec driver.

Still driver stuff. But another point is that kernel handles well always
on rails, so this property is completely redundant.

Best regards,
Krzysztof