Re: [PATCH 02/10] Add support for VMUFAT filesystem

[Matthew Wilcox]

On Fri, Apr 10, 2026 at 04:37:36PM +0100, Adrian McMenamin wrote:
> On Fri, 10 Apr 2026 at 15:38, Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:
> >
> 
> >
> > You should add an extry to Documentation/filesystems/index.rst too.
> >
> 
> That was sent but I had some trouble with it, but you should see it on
> the mailing list now.

I have to say this patch series is almost impossible to review.  I'm
not quite sure what you did, but it feels like you generated these
patches manually and then used git send-email to send them.

What I do is construct a git tree that contains all the patches I want
then generate a series like this:

git format-patch HEAD~4 -o pgtable-20251113 --to 'Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>' --cc 'David Hildenbrand <david@xxxxxxxxxx>' --cc 'Vishal Moola <vishal.moola@xxxxxxxxx>' --cc linux-mm@xxxxxxxxx --cover-letter

Then I scp them over to the machine which handles my email and use git
send-email on that machine to send the pgtable-20251113 directory full
of patches. 

The other thing that I'd advise you to be careful to do is make sure the
patch series is properly bisectable -- for example, you're adding the
Kconfig options before the Makefile and the Makefile before the files
that it would make.  I'd invert that order; add all the code, then the
Makefile, then the documentation.