Re: [PATCH 02/10] Add support for VMUFAT filesystem

[Adrian McMenamin]

> On Fri, 10 Apr 2026 at 18:53, Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:
>>
>> On Fri, Apr 10, 2026 at 04:37:36PM +0100, Adrian McMenamin wrote:
>> > On Fri, 10 Apr 2026 at 15:38, Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:
>>
>> I have to say this patch series is almost impossible to review.  I'm
>> not quite sure what you did, but it feels like you generated these
>> patches manually and then used git send-email to send them.
>>
>
I know it's not great. But there are 101 commits in the changes ( you
can see them all as a git pull request here -
https://github.com/mcmenaminadrian/linux/pull/1/changes ) - as this is
something I've been working on for some time, so I couldn't see a
rational way to use git format-patch. So I ended up using splitdiff on
the full change set as that at least broke the changes up file by
file. I then used git send-email on those. I didn't realise I could
have edited those generated patches statically before using git
send-email unfortunately.
>
>
>
>>
>> What I do is construct a git tree that contains all the patches I want
>> then generate a series like this:
>>
>> git format-patch HEAD~4 -o pgtable-20251113 --to 'Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>' --cc 'David Hildenbrand <david@xxxxxxxxxx>' --cc 'Vishal Moola <vishal.moola@xxxxxxxxx>' --cc linux-mm@xxxxxxxxx --cover-letter
>>
>
So, if I understand you correctly I basically should break the change
into a small number (4 or 5?) of logical units and submit them? I
think I can see how that would work and I will give it a go in due
course.
>
>>
>> Then I scp them over to the machine which handles my email and use git
>> send-email on that machine to send the pgtable-20251113 directory full
>> of patches.
>>
>> The other thing that I'd advise you to be careful to do is make sure the
>> patch series is properly bisectable -- for example, you're adding the
>> Kconfig options before the Makefile and the Makefile before the files
>> that it would make.  I'd invert that order; add all the code, then the
>> Makefile, then the documentation.
>
>
Thanks (and apologies if you get this twice as I forgot to turn off
HTML email earlier)