Re: [PATCH v3] staging: nvec: fix unconditional pm_power_off teardown

[Greg KH]

On Mon, Apr 13, 2026 at 10:02:03PM +0200, Alexandru Hossu wrote:
> tegra_nvec_remove() unconditionally sets pm_power_off = NULL, even if
> nvec was not the one that registered it. This breaks any other driver
> that may have set pm_power_off to its own handler.
> 
> Replace the unconditional assignment with a guarded check so that
> pm_power_off is only cleared if nvec was the one that set it.
> 
> Also remove the stale FIXME comment, as the guard addresses exactly
> what it was asking for.
> 
> Signed-off-by: Alexandru Hossu <hossu.alexandru@xxxxxxxxx>
> ---
> v3:
>  - Drop incorrect Fixes tag

I'm confused, I see lots of different patches here, with this final
thread looking like this:

 Apr 13 Alexandru Hossu (  51) [PATCH v2 1/2] staging: nvec: fix use-after-free in nvec_rx_completed()
 Apr 13 Alexandru Hossu (  40) └─>[PATCH v2 2/2] staging: nvec: fix unconditional pm_power_off teardown
 Apr 13 Dan Carpenter   (  26)   ├─>
 Apr 13 Alexandru Hossu (  42)   └─>[PATCH v3] staging: nvec: fix unconditional pm_power_off teardown

What is patch v3 of?  What about patch 1/2?

This is really confusing.

When redoing a patch in a series, you need to resend the whole series as
a new version.  Otherwise I have no idea what to do (and our tools get
_VERY_ confused as well.)

So a v4 full series please?

thanks,

greg k-h